feat: add Crimson Nylium and Warped Nylium blocks #6481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+43
to
+44
| $lightAbove = $world->getFullLightAt((int) $this->position->x, (int) $this->position->y + 1, (int) $this->position->z); | ||
| if($lightAbove < 4 && $world->getBlockAt((int) $this->position->x, (int) $this->position->y + 1, (int) $this->position->z)->getLightFilter() >= 2){ |
There was a problem hiding this comment.
Better to use getSide(Facing::UP)
Comment on lines
+38
to
+39
| $supportBlock->getTypeId() === BlockTypeIds::CRIMSON_NYLIUM || | ||
| $supportBlock->getTypeId() === BlockTypeIds::WARPED_NYLIUM || |
There was a problem hiding this comment.
Better to create a new Nylium tag for that is think
|
|
||
| class RedMushroom extends Flowable{ | ||
| use StaticSupportTrait; |
There was a problem hiding this comment.
Apply only minimal change, this is unrelated to the PR "add Crimson Nylium".
Open an other PR if you want to change that.
Comment on lines
+937
to
+938
| self::register("crimson_nylium", new GrassNylium(new BID(Ids::CRIMSON_NYLIUM), "Crimson Nylium", new Info(BreakInfo::pickaxe(0.4)))); | ||
| self::register("warped_nylium", new GrassNylium(new BID(Ids::WARPED_NYLIUM), "Warped Nylium", new Info(BreakInfo::pickaxe(0.4)))); |
There was a problem hiding this comment.
Can be good to store in an variable the break info
ipad54
reviewed
Nov 4, 2024
| use pocketmine\block\utils\BlockEventHelper; | ||
| use pocketmine\item\Item; | ||
|
|
||
| class GrassNylium extends Opaque{ |
There was a problem hiding this comment.
Nylium or NetherNylium would be better.
|
Bonemeal logic is missing. Also, this PR should target |
|
There is no block available for bone meal spreading, roots and fungus is missing |
Roots are implemented. https://github.com/pmmp/PocketMine-MP/blob/stable/src/block/NetherRoots.php |
dktapps
reviewed
Nov 4, 2024
| @@ -983,6 +984,7 @@ private function registerSimpleDeserializers() : void{ | |||
| $this->mapSimple(Ids::TUFF_BRICKS, fn() => Blocks::TUFF_BRICKS()); | |||
| $this->mapSimple(Ids::UNDYED_SHULKER_BOX, fn() => Blocks::SHULKER_BOX()); | |||
| $this->mapSimple(Ids::WARPED_WART_BLOCK, fn() => Blocks::WARPED_WART_BLOCK()); | |||
| $this->mapSimple(Ids::WARPED_NYLIUM, fn() => Blocks::WARPED_NYLIUM()); | |||
dktapps
reviewed
Nov 4, 2024
| @@ -1060,6 +1061,7 @@ private function registerSimpleSerializers() : void{ | |||
| $this->mapSimple(Blocks::TUFF(), Ids::TUFF); | |||
| $this->mapSimple(Blocks::TUFF_BRICKS(), Ids::TUFF_BRICKS); | |||
| $this->mapSimple(Blocks::WARPED_WART_BLOCK(), Ids::WARPED_WART_BLOCK); | |||
| $this->mapSimple(Blocks::WARPED_NYLIUM(), Ids::WARPED_NYLIUM); | |||
jasonw4331
added
Category: Gameplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Crimson NyliumandWarped Nyliumblocks addedTests
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)